Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: diff.printBasicPrototype: false by default #7043

Merged
merged 3 commits into from
Dec 9, 2024
Merged

feat: diff.printBasicPrototype: false by default #7043

merged 3 commits into from
Dec 9, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Dec 7, 2024 •
edited
Loading

Description

We've been using printBasicPrototype: false for snapshot, but diff formatting was still true for some reason.

Before

image

After

image

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify Netlify
Copy link

netlify bot commented Dec 7, 2024

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9d12a3e
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6753c51fca35e10008d52073
😎 Deploy Preview https://deploy-preview-7043--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review December 7, 2024 10:12
@sheremet-va sheremet-va merged commit 2b5c520 into vitest-dev:main Dec 9, 2024
17 checks passed
@hi-ogawa hi-ogawa deleted the feat-diff-printBasicPrototype-false branch December 9, 2024 09:21
@sheremet-va sheremet-va mentioned this pull request Dec 9, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hi-ogawa @sheremet-va